feat(ReactNodeViewRenderer): Add as
option and pass through to ReactRenderer
#2213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
ReactNodeViewRenderer
renders as a<div class="react-renderer">
wrapper. We'd like to be able to pass anas
prop to specify what kind of top-level HTMLElement corresponds with our node content. This could give people are a more granular control over how their elements get added (i.e. instead of justdiv
orspan
, we could let people render animg
orli
directly).At Gamma, our main use case is to allow us to have
li
elements adjacent to each other (rather than nested inside the div produced by ReactNodeViewRenderer).Additionally, (and for a separate PR), we like being able to pass the top-level
<li>
anindent
attribute to dynamically do counter-resets. Right now there's no flexibility to add arbitrary attributes to the outermost wrapper when you useReactNodeViewRenderer
, so we're working on a way to do this in our own fork. We'll probably attempt this in a separate PR.